@alexanderrich

Signed up since Aug. 15, 2017

Points

Timestamp Points Contributor Ad-hoc References
Sept. 5, 2017 20 @alexanderrich No Issues #11
PR #67
Aug. 23, 2017 3 @alexanderrich No Issues #54

Activity

@alexanderrich commented on PR #67: Improve error handling in prediction API

Good point, just made that quotation-mark fix and squashed with previous commit
1 year, 3 months ago

@alexanderrich commented on PR #67: Improve error handling in prediction API

(1) and (3) are resolved, but it looks like Travis is encountering the same issue.
1 year, 3 months ago

@alexanderrich commented on PR #67: Improve error handling in prediction API

Great, I'll fix (1) and (3). (2) seems connected to Issue #69 - I noticed that Travis failed after my first and third commits, but ran successfully on my second, so I think the issue is external.
1 year, 3 months ago

@alexanderrich opened a new pull request: #67: improve error handling in prediction API

Prediction API now returns message specifying if a needed parameter is not passed to the prediction algorithm, and passes error messages that occur within the prediction algorithm. ## Description The API passes an error message if a non-existent algorithm is selected, as before. The API now also passes an error message if a necessary parameter to the algorithm is missing, specifying the algorithm chosen and the required parameter. All other errors (e.g., bad DICOM file path) should be caught within the prediction algorithm, and these messages are caught and passed through the API. ## Reference to official issue Fixes issue #11 ## How Has This Been Tested? These changes are tested through additional tests in test_endpoints.py. To properly test the response to bad DICOM paths, I modified the "predict" functions of the three "trained_model.py" modules to load the passed DICOM path. This loaded image is currently simply discarded after loading. ## Screenshots (if appropriate): ## CLA - [x] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well
1 year, 3 months ago

@alexanderrich commented on issue #54: External links in https://concepttoclinic.drivendata.org/documentation do not work

Ah I see, makes sense! Opening external pages in new tabs seems like a good solution. Simply having the developer docs link on concepttoclinic.drivendata.org direct straight to the readthedocs page rather than containing the readthedocs page in an iframe seems reasonable as well - that's where I've been reading them since running into this problem.
1 year, 3 months ago

@alexanderrich created a new issue: #54: External links in https://concepttoclinic.drivendata.org/documentation do not work

## Expected Behavior When viewing the documentation through https://concepttoclinic.drivendata.org/documentation, external links should take the browser to a new webpage. ## Current Behavior Clicking external links (at least in Firefox and Chrome) leads to a page with the "Concept to Clinic" heading that is otherwise blank. ## Possible Solution It looks like the documentation page uses an iframe to display the a readthedocs page. I think this iframe might need to be reconfigured to allow redirecting the target of its parent window. Since concepttoclinic.drivendata.org isn't controlled by this public github repo, I think and admin will have to fix this. ## Steps to Reproduce 1. Open https://concepttoclinic.drivendata.org/documentation 2. Go to "Getting Started" 3. Click the "submitting a PR to the GitHub repository" link. 4. The screen goes blank.
1 year, 4 months ago