@eltonlaw

Signed up since Aug. 22, 2017

Points

Timestamp Points Contributor Ad-hoc References
Sept. 11, 2017 2 @eltonlaw No Issues #96
Sept. 11, 2017 20 @eltonlaw No Issues #15
PR #83

Activity

@eltonlaw commented on PR #83: #15 - Add links to the project structure documentation

sweet that worked great thanks, btw I left the rest of the old commit message in the body
1 year, 3 months ago
1 year, 3 months ago

@eltonlaw created a new issue: #96: Double requirement given (sphinx_rtd_theme==0.2.4 and sphinx_rtd_theme==0.1.9)

<!--- Provide a general summary of the issue in the Title above --> ## Detailed Description When running `pip install -r requirements.txt` I get the following issue: ``` Double requirement given: sphinx_rtd_theme==0.2.4 (from -r requirements.txt (line 7)) (already in sphinx_rtd_theme==0.1.9 (from -r prediction/requirements/local.txt (line 6)), name='sphinx-rtd-theme') ``` This stems from the [master `requirements.txt`](https://github.com/concept-to-clinic/concept-to-clinic/blob/master/requirements.txt) file specifying `sphinx_rtd_theme==0.2.4` in line 7 and the file in [`prediction/requirements/local.txt` specifying `sphinx_rtd_theme==0.1.9`](https://github.com/concept-to-clinic/concept-to-clinic/blob/master/prediction/requirements/local.txt) in line 6. Is this on purpose, or should we update/delete the line in `prediction/requirements/local.txt`? ## Steps to Reproduce <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. Include code to reproduce, if relevant --> I actually can't seem to reproduce this bug, I don't remember the steps I ran to get the error, I tried using a fresh virtualenv and pip installing with the `--no-cache` flag but no good it ran smoothly...so the severity of this issue is minuscule I guess, just a problem of keeping the dependencies aligned in the two requirements.txt files ## Possible Implementation Delete line in `prediction/requirements/local.txt` ## Checklist before submitting - [x] I have confirmed this using the officially supported Docker Compose setup using the `local.py` configuration and ensured that I built the containers again and they reflect the most recent version of the project at the `HEAD` commit on the `master` branch - [x] I have searched through the other currently open issues and am confident this is not a duplicate of an existing bug - [x] I provided a **minimal code snippet** or list of steps that reproduces the bug. - [x] I provided **screenshots** where appropriate - [x] I filled out all the relevant sections of this template
1 year, 3 months ago

@eltonlaw commented on PR #83: #15 - Add links to the project structure documentation

@reubano For verification, here's how it looks running make, everything should be just as is, is this okay to merge? ![screen shot 2017-09-06 at 7 00 57 pm](https://user-images.githubusercontent.com/14999531/30138344-ca4c4d08-9335-11e7-9688-700bfc442976.png)
1 year, 3 months ago

@eltonlaw commented on PR #83: #15 - Add links to the project structure documentation

@lamby Well I tried that, it didn't work either. But I fixed it in a hacky way, I just deleted `apidoc_interface` and it builds now with `make html`, so there's that. Sorry I really should have thought of that earlier. Oh by the way, here's the error message when running `DJANGO_SETTINGS_MODULE=config.settings.local make html` if you want to debug it: https://pastebin.com/wxXHwJpB @reubano Sorry for the delay here's a screenshot of how it renders without the CSS. It looks less clean imo, if the only problem is that the <style> stuff renders as text on GitHub do you want to throw it all into `_static/c2c_custom.css` adding id="structure-tr" to all <tr> tags and with the following names? ``` tr.structure-tr:nth-child(odd) { ... } table#structure-table { ... } ``` ![screen shot 2017-09-05 at 5 46 08 pm](https://user-images.githubusercontent.com/14999531/30084876-35bc0684-9262-11e7-953c-a48918232772.png)
1 year, 3 months ago

@eltonlaw commented on PR #83: resubmit to solve #15

Whoops sorry about that, here's the [error message](https://pastebin.com/fZcLaX0S) Yeah I _think_ I did everything: * Created a virtualenv and activated it * `pip install -r requirements.txt` * `docker-compose -f local.yml build` * `docker-compose -f local.yml up`. * `cd docs/` * `make html` I've tried cloning a fresh repo and running the above but I still get an error, it's a slightly different error message: [[Error Message](https://pastebin.com/ErbMb6Vh) | [Traceback](https://pastebin.com/u5qW1tmn)] Oh by the way random note, while messing around with the installation process I get ``` Double requirement given: sphinx_rtd_theme==0.2.4 (from -r requirements.txt (line 7)) (already in sphinx_rtd_theme==0.1.9 (from -r prediction/requirements/local.txt (line 6)), name='sphinx-rtd-theme') ``` Is this on purpose?
1 year, 3 months ago

@eltonlaw commented on PR #83: resubmit to solve #15

@lamby Yeah, I can't seem to run make anymore without django throwing an error. autodoc can't import stuff from `backend` because the django settings are improperly configured, it says that I need to define the environment variable `DJANGO_SETTINGS_MODULE`. Any ideas on how to fix this or bypass this, since I really only need to render the one file. If this seems like a headache to deal with feel free to pass this issue to someone else.
1 year, 3 months ago

@eltonlaw opened a new pull request: #83: resubmit to solve #15

<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> (resubmission of PR#64 - couldn't just reopen it cause I deleted the old fork and there was some weird merging thing going on) Hi, I've added links for everything below. There weren't any explicit instructions on where to link so I just linked to the documentation home for the most part. On some occasions, I would link to a specific part of the documentation (Django Migrations, Docker Containers etc.): * Docker * docker-compose * sphinx * Django * Django Rest Framework * Vue.js * Django database migrations * requirements.txt * DICOM * git-lfs * Flask * flake8 Links not added (there didn't seem to be any place to put them, advice?): * pip * pytest Oh yea, while I was looking through it I found some minor typos so I also added those changes. ## Reference to official issue <!--- If fixing a bug, there should be an existing issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> #15 - Add links to the project structure documentation ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If adding a new feature or making improvements not already reflected in an official issue, please reference the relevant sections of the design doc --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> I tested with make html and it built with no error. I also ran it and went through and clicked on each link. ## Screenshots (if appropriate): ## CLA - [x] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well
1 year, 3 months ago

@eltonlaw commented on PR #56: Add links to project structure documentation

Sure, I'll reopen the old pull request. Are there any changes you want to add to the current commit?
1 year, 3 months ago

@eltonlaw commented on PR #64: Add links to the project structure documentation (#15)

whoops didn't realize someone already submitted something
1 year, 3 months ago

@eltonlaw opened a new pull request: #64: Add links to the project structure documentation

#15 Added links for the following: - Docker - docker-compose - sphinx - Django - Django Rest Framework - Vue.js - Django database migrations - requirements.txt (and pip) - DICOM - git-lfs - Flask - flake8 Links not added for: - pip - pytest Also Added: - Some spelling errors - Fixed table nesting structure for docker-compose tree <!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Reference to official issue <!--- If fixing a bug, there should be an existing issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If adding a new feature or making improvements not already reflected in an official issue, please reference the relevant sections of the design doc --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ## CLA - [ ] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well
1 year, 3 months ago