@truefalse10

Signed up since Oct. 11, 2017

Points

Timestamp Points Contributor Ad-hoc References
Nov. 26, 2017 2 @truefalse10 No Issues #167
Oct. 18, 2017 5 @truefalse10 No Issues #162
PR #171
Oct. 17, 2017 3 @truefalse10 No Issues #167
PR #168

Activity

@truefalse10 commented on issue #215: Eliminate/Restrict Jquery use for cornerstone-tools

is anyone working on this right now? otherwise i would start
1 year, 1 month ago

@truefalse10 opened a new pull request: #171: Fixing error unhandled promise rejection #162, removing VueResource

as described in #162 with node 8 an error is thrown after starting the vuejs dev-server. This is caused by the dev-server trying to start a browser window inside the docker container which leads to a rejected promise. This PR fixes this issues. Additionally it improves the following: * remove VueResource (we use axios for http requests as i understood, therefore VueResource is not needed anymore) * fix current axios requests to also handle rejected promises correctly with catch statements * add correct node_modules path to .dockerignore
1 year, 2 months ago

@truefalse10 opened a new pull request: #168: Install sass-loader, refactor .vue components to use scss #167

Will install sass-loader and update all components to use scss. #167 # Motivation The current vue.js setup allows only to write styles in pure css. This can be quite time consuming, error-prone and leads to redundant code. In order to use variables, mixins and all other handy tools I would suggest using a preprocessor. In vuejs this can be easily achieved by installing the preferred webpack [loader](https://vue-loader.vuejs.org/en/configurations/pre-processors.html). My suggestions would be to use SCSS because it has the same syntax as CSS and can therefore easily be adapted by people new to preprocessores. ## Expected Behavior I can write component styles with scss/sass/less/stylus and it gets compiled to css ## Current Behavior using `<style lang="scss">` leads to compile time error ## Possible Solution install missing webpack loaders
1 year, 2 months ago

@truefalse10 created a new issue: #167: Use css preprocessor like sass, less...

The current vue.js setup allows only to write styles in pure css. This can be quite time consuming, error-prone and leads to redundant code. In order to use variables, mixins and all other handy tools I would suggest using a preprocessor. In vuejs this can be easily achieved by installing the preferred webpack [loader](https://vue-loader.vuejs.org/en/configurations/pre-processors.html). My suggestions would be to use SCSS because it has the same syntax as CSS and can therefore easily be adapted by people new to preprocessores. ## Expected Behavior I can write component styles with scss/sass/less/stylus and it gets compiled to css ## Current Behavior using `<style lang="scss">` leads to compile time error ## Possible Solution install missing webpack loaders
1 year, 2 months ago